Fix tag dropdown not finalizing selection - #13490
Open
abdosaeedelhassan wants to merge 1 commit into
Open
Conversation
varjolintu
added
the
pr: ai-assisted
When selecting a tag from the completer dropdown, the selection now immediately finalizes into a tag pill instead of requiring an extra action. Fixes keepassxreboot#13444 [skip ci] Fix 2 of 10 — GUI entry fixes
abdosaeedelhassan
force-pushed
the
fix/gui-entry-fixes
branch
from
July 3, 2026 11:57
94acb3b to
dfc3a89
Compare
droidmonkey
requested changes
Jul 23, 2026
Comment on lines
+265
to
+269
| void PasswordWidget::setPasswordStrength(const QString& password) | ||
| { | ||
| updatePasswordStrength(password); | ||
| } | ||
|
|
| void selectAll(); | ||
| void setReadOnly(bool state); | ||
| void setEchoMode(QLineEdit::EchoMode mode); | ||
| void setPasswordStrength(const QString& password); |
Comment on lines
+1027
to
+1029
| if (entry->isAttributeReference("Password")) { | ||
| m_mainUi->passwordEdit->setPasswordStrength(entry->resolveMultiplePlaceholders(entry->password())); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When selecting a tag from the completer dropdown, the selection now immediately finalizes into a tag pill instead of requiring an extra action.
Fixes #13444
[skip ci] Fix 2 of 10 — GUI entry fixes
Screenshots
Testing strategy
Type of change